Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory usage optimization #90

Open
YooSunYoung opened this issue Nov 12, 2024 · 4 comments
Open

Memory usage optimization #90

YooSunYoung opened this issue Nov 12, 2024 · 4 comments

Comments

@YooSunYoung
Copy link
Member

The workflow crashes a kernel in a 16 GB VISA instance.

Number of Pixels: 4915200
(McStas file) Number of Rows: ?

16 GB of memory is expected to be enough.
We need to see why it crashes or see how we can optimize it.

@aaronfinke
Copy link
Collaborator

Please note the crash happens on a VISA instance at ILL, not ESS. However, the performance on the ESS VISA instance is very poor (might be an unrelated issue).

@SimonHeybrock
Copy link
Member

Please add more details:

@aaronfinke
Copy link
Collaborator

@SimonHeybrock
Copy link
Member

One thing that should in my opinion be avoided is the "merging of panels". It just adds overhead, and implies that just for the merge step we need a minimum 6x the size of a single panel in terms of memory. If all we want is write all panels to the same file (or even dataset), that can be achieved without merging as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants