Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid scipy_proc.json does not raise an invalid json error #315

Closed
mpacer opened this issue Jul 13, 2017 · 1 comment
Closed

Invalid scipy_proc.json does not raise an invalid json error #315

mpacer opened this issue Jul 13, 2017 · 1 comment
Labels

Comments

@mpacer
Copy link
Contributor

mpacer commented Jul 13, 2017

If you write an invalid json file, it should raise an error when it is read in.

Currently if you include an invalid json file, e.g.:

{
  "proceedings": {
     "citation_key": "proc-scipy-2017",
     "title": {
       "acronym": "SciPy",
       "conference": "Python in Science Conference",
       "ordinal": "15th",
       "short": "PROC. OF THE 15th PYTHON IN SCIENCE CONF. (SCIPY 2017)",
       "full": "Proceedings of the 15th Python in Science Conference"
     },
     "year": "2017",
     "editor": [
        "Katy Huff",
        "David Lippa",
        "Dillon Niederhut",
        "M Pacer"
     ],
     "volume": 3,
     "number": 1,
     "isbn": "value",
     "location": "Austin, Texas",
     "dates": "July 10 - July 16",
     "copyright": {
       "article": "This is an open-access article distributed under the terms of the Creative Commons Attribution License, which permits unrestricted use, distribution, and reproduction in any medium, provided the original author and source are credited.",
       "proceedings": ["The articles in the Proceedings of the Python in Science Conference are copyrighted and owned by their original authors",
                       "This is an open-access publication and is distributed under the terms of the Creative Commons Attribution License, which permits unrestricted use, distribution, and reproduction in any medium, provided the original author and source are credited.",
                       "For more information, please see:  http://creativecommons.org/licenses/by/3.0/"],
       "license": "Creative Commons Attribution License (CCAL)"}
  },
  "organization": [

        {
            "name": "Proceedings",
            "members": [
                {"name": "Katy Huff",
                 "org": "University of Illinois"},
                {"name": "David Lippa",
                 "org": "Amazon"},
                {"name": "Dillon Niederhut",
                 "org": "Enthought"},
                {"name": "M Pacer",
                 "org": "Berkeley Institute of Data Science"}
                ]
        },
            "name": "Proceedings Reviewers",
            "members": [
                {"name" : "David Lippa"},
                {"name" : "Katy Huff"},
                {"name" : "M Pacer"},
                {"name" : "Dillon Niederhut"},
                ]
        }
    ]

}

(note the absence of an opening { before the element "name": Proceedings Reviewers", )

then running any of the make commands raises an error that has nothing to do with reading the json in. It just raises an error that the top level key that is being looked for (whether it's proceedings or organization respectively for make proceedings & make organization-pdf). That suggests that the conf is being loaded but not being checked to see if it is valid (or that's being caught and not raised).

@rowanc1
Copy link
Contributor

rowanc1 commented Nov 5, 2024

This should be fixed by #1016 when merged.

@rowanc1 rowanc1 closed this as completed Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants