Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bespoke URL work and replace with linkifyjs #21

Open
marksyzm opened this issue Jan 31, 2016 · 10 comments
Open

Remove bespoke URL work and replace with linkifyjs #21

marksyzm opened this issue Jan 31, 2016 · 10 comments

Comments

@marksyzm
Copy link

Some people have done a lot of work to make links and hashtags work with this plugin and I think it'd be worth it to just implement those instead to cover all bases. I know this means removing identity of what this plugin is, but maybe you'd get more recognition?

See here: LinkifyJS

@marksyzm
Copy link
Author

I'm going to do a fork pretty soon, but assume that it's pretty much a full rewrite with the same functionality :)

@scottcorgan
Copy link
Owner

@marksyzm, it's great idea! I wrote this around the same time that was being written, so I was unaware of it. Please feel free to open an PR and we can get that in there!

@marksyzm
Copy link
Author

marksyzm commented Feb 1, 2016

Will do :) I'm trying to get it working as it is at the moment with my current build, then I'll send it over. Might have to add in webpack if that's okay with you, so people can just install it as a whole bundle.

@scottcorgan
Copy link
Owner

Guild process doesn't really matter. As long as there's a dist folder. Might want to add some tests too.

@marksyzm
Copy link
Author

marksyzm commented Feb 4, 2016

I've basically written the library already (within my own system, so I could test it against a real setup) and I've submitted these so we've got a proper plugin for mentions first:
nfrasser/linkifyjs#111
nfrasser/linkifyjs#112

Then I'll chuck this all together via a fork from your repo, chuck some tests together and then work on the build output for making it work nicely via bower and npm. Shouldn't take too long!

@scottcorgan
Copy link
Owner

Sounds good. I can give you access to the repo too when you're ready.

@marksyzm
Copy link
Author

marksyzm commented Feb 5, 2016

As a collaborator? Cool - I don't mind just doing it from a fork and send a PR over but that's up to you. I'm pretty close to ready so I can make a start tonight (or over the weekend, rather) if you want.

@scottcorgan
Copy link
Owner

You can probably just open a PR, once I merge it in, I can add you as a collaborator. It'll be good to get some fresh eyes on the repo as I haven't been in Angular land for quite a few years.

@marksyzm
Copy link
Author

marksyzm commented Feb 8, 2016

Here we go! #22
Haven't got the tests in yet, but I'll knock them up ASAP. Go take a look and see if that works for you. I can't work out how to stop webpack from building linkifyjs into the dist build for bower/stand alone use but otherwise, we're good. It builds to UMD too!

@marksyzm
Copy link
Author

marksyzm commented Feb 8, 2016

Oh and that seems to fix pretty much all the issues mentioned in your recent list (with a little refactoring on their part).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants