Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Description
Added dtslint
$ExpectType
to most places in tests, this makes it easier/possible to split tests across multiple files and to accurately test is a type is what it is supposed to be.Another benefit is that we can remove a lot of unnecessary "hacky" code from the tests that were previously used to make typescript complain
There are some issues that need to be dealt with before this can be merged
describeExits return type is evaluated as
Partial<Record<ExitKey, string>>
even though it is specified as
describeExits(roomName: string): ExitsInformation;
dtslint is order sensitive and this one likes to shuffle around
Checklists
src/
files notindex.d.ts
npm run dtslint
to updateindex.d.ts