Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dtslint assert types #202

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

IotaBlack
Copy link
Contributor

Brief Description

Added dtslint $ExpectType to most places in tests, this makes it easier/possible to split tests across multiple files and to accurately test is a type is what it is supposed to be.
Another benefit is that we can remove a lot of unnecessary "hacky" code from the tests that were previously used to make typescript complain

There are some issues that need to be dealt with before this can be merged

image
describeExits return type is evaluated as Partial<Record<ExitKey, string>>
even though it is specified as describeExits(roomName: string): ExitsInformation;

image
dtslint is order sensitive and this one likes to shuffle around

Checklists

  • Test passed
  • Coding style (indentation, etc)
  • Edits have been made to src/ files not index.d.ts
  • Run npm run dtslint to update index.d.ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant