Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update invader core-related constants to their actual values #249

Merged
merged 1 commit into from
Dec 2, 2023
Merged

Update invader core-related constants to their actual values #249

merged 1 commit into from
Dec 2, 2023

Conversation

tiennou
Copy link
Contributor

@tiennou tiennou commented Dec 2, 2023

Just found out a couple mismatches, none of which are important except INVADER_CORE_EXPAND_TIME which is keyed by the core's level now, thus breaking.

Checklists

  • Test passed
  • Coding style (indentation, etc)
  • Edits have been made to src/ files not index.d.ts
  • Run npm run dtslint to update index.d.ts

@tiennou
Update invader core-related constants to their actual values
18b3bf7 
The only one that's breaking is `INVADER_CORE_EXPAND_TIME` which is
keyed by the core's level now.
@DiamondMofeng DiamondMofeng self-requested a review December 2, 2023 01:45
@DiamondMofeng DiamondMofeng merged commit 1e39c4f into screepers:master Dec 2, 2023
3 checks passed
@tiennou
Copy link
Contributor Author

tiennou commented Dec 2, 2023

Thanks!

@tiennou tiennou deleted the fix/invasion-core-consts branch December 2, 2023 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DiamondMofeng DiamondMofeng DiamondMofeng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tiennou @DiamondMofeng