-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #252: lookForAtArea matrix result type. #253
Conversation
We are missing tests for this change, it is a bit hard to see what this actually accomplishes in the context of this PR. |
I thought I did add the tests, but maybe I am missing something about the project structure? Thought dist/screeps-tests.ts contains tests, I added lines 919 - 921 with a test from the issue reported and fixed previous test - line 911. |
You did, I just didn't have coffee yet 😅 |
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this issue
Brief Description
Fix incorrect typing for return value of room.lookForAtArea matrix form (isArray = false)
Checklists
src/
files notindex.d.ts
npm run dtslint
to updateindex.d.ts