Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Game.market.deal documentation #256

Merged
merged 3 commits into from
Mar 31, 2024

Conversation

MatthewGlancy
Copy link
Contributor

Brief Description

I use typed screeps as a helper in my own codebase to get autocomplete via vs code from default JS. I noticed that Game.market.deal had some slight differences compared to the official docs. Had a misleading targetRoomName, when it should be yourRoomName and I've added some documentation for the parameters (paraphrasing from official docs)

Checklists

  • Test passed
  • Coding style (indentation, etc)
  • Edits have been made to src/ files not index.d.ts
  • Run npm run dtslint to update index.d.ts

@DiamondMofeng DiamondMofeng self-requested a review February 24, 2024 18:07
Copy link
Member

@DiamondMofeng DiamondMofeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you ❤️

@DiamondMofeng DiamondMofeng merged commit 79884ad into screepers:master Mar 31, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants