Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/Remove ZK from Spartan Backend #53

Merged
merged 13 commits into from
Dec 10, 2024
Merged

Feat/Remove ZK from Spartan Backend #53

Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
d134a9f
Remove zk
darth-cy Dec 4, 2024
d4e022b
Remove blinds
darth-cy Dec 4, 2024
acbc979
remove nizk
kunxian-xia Dec 5, 2024
4b160ca
Adapt proving methods onto SumcheckInstanceProof. Remove ZK proof str…
darth-cy Dec 5, 2024
d1bfaca
Revert "Adapt proving methods onto SumcheckInstanceProof. Remove ZK p…
darth-cy Dec 5, 2024
6b39853
Resolve compilation issues
darth-cy Dec 6, 2024
a8ba63f
Remove additional commitment proofs
Dec 6, 2024
7d12338
fmtr
darth-cy Dec 6, 2024
ce6cd4e
Remove debug flag
darth-cy Dec 9, 2024
aa19362
Remove blinds
darth-cy Dec 9, 2024
e905720
Remove random tape
darth-cy Dec 9, 2024
1a4fdb3
Remove PolyEvalProof prove, verify logic
darth-cy Dec 9, 2024
abef32a
fmt
darth-cy Dec 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
173 changes: 32 additions & 141 deletions spartan_parallel/src/dense_mlpoly.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ use crate::scalar::SpartanExtensionField;

use super::errors::ProofVerifyError;
use super::math::Math;
use super::nizk::DotProductProofLog;
use super::random::RandomTape;
use super::transcript::ProofTranscript;
use core::ops::Index;
Expand All @@ -21,10 +20,6 @@ pub struct DensePolynomial<S: SpartanExtensionField> {
Z: Vec<S>, // evaluations of the polynomial in all the 2^num_vars Boolean inputs
}

pub struct PolyCommitmentBlinds<S: SpartanExtensionField> {
pub(crate) blinds: Vec<S>,
}

pub struct EqPolynomial<S: SpartanExtensionField> {
r: Vec<S>,
}
Expand Down Expand Up @@ -258,7 +253,12 @@ impl<S: SpartanExtensionField> DensePolynomial<S> {
assert_eq!(r.len(), self.get_num_vars());
let chis = EqPolynomial::new(r.to_vec()).evals();
assert_eq!(chis.len(), self.Z.len());
DotProductProofLog::compute_dotproduct(&self.Z, &chis)
Self::compute_dotproduct(&self.Z, &chis)
}

fn compute_dotproduct(a: &[S], b: &[S]) -> S {
assert_eq!(a.len(), b.len());
(0..a.len()).map(|i| a[i] * b[i]).sum()
}

fn vec(&self) -> &Vec<S> {
Expand Down Expand Up @@ -311,7 +311,7 @@ impl<S: SpartanExtensionField> Index<usize> for DensePolynomial<S> {

#[derive(Clone, Debug, Serialize, Deserialize)]
pub struct PolyEvalProof<S: SpartanExtensionField> {
proof: DotProductProofLog<S>,
v: Vec<S>,
}

impl<S: SpartanExtensionField> PolyEvalProof<S> {
Expand All @@ -321,12 +321,10 @@ impl<S: SpartanExtensionField> PolyEvalProof<S> {

pub fn prove(
poly: &DensePolynomial<S>,
blinds_opt: Option<&PolyCommitmentBlinds<S>>,
r: &[S], // point at which the polynomial is evaluated
Zr: &S, // evaluation of \widetilde{Z}(r)
blind_Zr_opt: Option<&S>, // specifies a blind for Zr
r: &[S], // point at which the polynomial is evaluated
_Zr: &S, // evaluation of \widetilde{Z}(r)
transcript: &mut Transcript,
random_tape: &mut RandomTape<S>,
_random_tape: &mut RandomTape<S>,
) -> PolyEvalProof<S> {
<Transcript as ProofTranscript<S>>::append_protocol_name(
transcript,
Expand All @@ -340,32 +338,16 @@ impl<S: SpartanExtensionField> PolyEvalProof<S> {
let L_size = left_num_vars.pow2();
let R_size = right_num_vars.pow2();

let default_blinds = PolyCommitmentBlinds {
blinds: vec![S::field_zero(); L_size],
};
let blinds = blinds_opt.map_or(&default_blinds, |p| p);

assert_eq!(blinds.blinds.len(), L_size);

let zero = S::field_zero();
let blind_Zr = blind_Zr_opt.map_or(&zero, |p| p);

// compute the L and R vectors
let eq = EqPolynomial::new(r.to_vec());
let (L, R) = eq.compute_factored_evals();
assert_eq!(L.len(), L_size);
assert_eq!(R.len(), R_size);

// compute the vector underneath L*Z and the L*blinds
// compute vector-matrix product between L and Z viewed as a matrix
let LZ = poly.bound(&L);
let LZ_blind: S = (0..L.len()).map(|i| blinds.blinds[i] * L[i]).sum();

// a dot product proof of size R_size
let proof =
DotProductProofLog::prove(transcript, random_tape, &LZ, &LZ_blind, &R, Zr, blind_Zr);

PolyEvalProof { proof }
PolyEvalProof { v: LZ }
}

pub fn verify(
Expand All @@ -380,9 +362,7 @@ impl<S: SpartanExtensionField> PolyEvalProof<S> {

// compute L and R
let eq = EqPolynomial::new(r.to_vec());
let (L, R) = eq.compute_factored_evals();

let _ = self.proof.verify(R.len(), transcript, &R);
let (_L, _R) = eq.compute_factored_evals();

// TODO: Alternative PCS Verification
Ok(())
Expand All @@ -403,12 +383,10 @@ impl<S: SpartanExtensionField> PolyEvalProof<S> {
// Evaluation of multiple points on the same instance
pub fn prove_batched_points(
poly: &DensePolynomial<S>,
blinds_opt: Option<&PolyCommitmentBlinds<S>>,
r_list: Vec<Vec<S>>, // point at which the polynomial is evaluated
Zr_list: Vec<S>, // evaluation of \widetilde{Z}(r) on each point
blind_Zr_opt: Option<&S>, // specifies a blind for Zr
r_list: Vec<Vec<S>>, // point at which the polynomial is evaluated
Zr_list: Vec<S>, // evaluation of \widetilde{Z}(r) on each point
transcript: &mut Transcript,
random_tape: &mut RandomTape<S>,
_random_tape: &mut RandomTape<S>,
) -> Vec<PolyEvalProof<S>> {
<Transcript as ProofTranscript<S>>::append_protocol_name(
transcript,
Expand All @@ -425,16 +403,6 @@ impl<S: SpartanExtensionField> PolyEvalProof<S> {
let L_size = left_num_vars.pow2();
let R_size = right_num_vars.pow2();

let default_blinds = PolyCommitmentBlinds {
blinds: vec![S::field_zero(); L_size],
};
let blinds = blinds_opt.map_or(&default_blinds, |p| p);

assert_eq!(blinds.blinds.len(), L_size);

let zero = S::field_zero();
let blind_Zr = blind_Zr_opt.map_or(&zero, |p| p);

// compute the L and R vectors
// We can perform batched opening if L is the same, so we regroup the proofs by L vector
// Map from the left half of the r to index in L_list
Expand Down Expand Up @@ -468,31 +436,14 @@ impl<S: SpartanExtensionField> PolyEvalProof<S> {
let mut proof_list = Vec::new();
for i in 0..L_list.len() {
let L = &L_list[i];
let R = &R_list[i];
// compute the vector underneath L*Z and the L*blinds
let _R = &R_list[i];
// compute vector-matrix product between L and Z viewed as a matrix
let LZ = poly.bound(L);
let LZ_blind: S = (0..L.len()).map(|i| blinds.blinds[i] * L[i]).sum();

// a dot product proof of size R_size
let proof = DotProductProofLog::prove(
transcript,
random_tape,
&LZ,
&LZ_blind,
R,
&Zc_list[i],
blind_Zr,
);
proof_list.push(proof);

proof_list.push(PolyEvalProof { v: LZ });
}

proof_list
.iter()
.map(|proof| PolyEvalProof {
proof: proof.clone(),
})
.collect()
}

pub fn verify_plain_batched_points(
Expand Down Expand Up @@ -546,12 +497,10 @@ impl<S: SpartanExtensionField> PolyEvalProof<S> {
// Size of each instance might be different, but all are larger than the evaluation point
pub fn prove_batched_instances(
poly_list: &Vec<DensePolynomial<S>>, // list of instances
blinds_opt: Option<&PolyCommitmentBlinds<S>>,
r_list: Vec<&Vec<S>>, // point at which the polynomial is evaluated
Zr_list: &Vec<S>, // evaluation of \widetilde{Z}(r) on each instance
blind_Zr_opt: Option<&S>, // specifies a blind for Zr
r_list: Vec<&Vec<S>>, // point at which the polynomial is evaluated
Zr_list: &Vec<S>, // evaluation of \widetilde{Z}(r) on each instance
transcript: &mut Transcript,
random_tape: &mut RandomTape<S>,
_random_tape: &mut RandomTape<S>,
) -> Vec<PolyEvalProof<S>> {
<Transcript as ProofTranscript<S>>::append_protocol_name(
transcript,
Expand Down Expand Up @@ -611,29 +560,8 @@ impl<S: SpartanExtensionField> PolyEvalProof<S> {
}

let mut proof_list = Vec::new();
for i in 0..LZ_list.len() {
let L = &L_list[i];
let L_size = L.len();

let default_blinds = PolyCommitmentBlinds {
blinds: vec![S::field_zero(); L_size],
};
let blinds = blinds_opt.map_or(&default_blinds, |p| p);
assert_eq!(blinds.blinds.len(), L_size);
let blind_Zr = blind_Zr_opt.map_or(&zero, |p| p);
let LZ_blind: S = (0..L.len()).map(|i| blinds.blinds[i] * L[i]).sum();

// a dot product proof of size R_size
let proof = DotProductProofLog::prove(
transcript,
random_tape,
&LZ_list[i],
&LZ_blind,
&R_list[i],
&Zc_list[i],
blind_Zr,
);
proof_list.push(PolyEvalProof { proof });
for v in LZ_list.into_iter() {
proof_list.push(PolyEvalProof { v });
}

proof_list
Expand Down Expand Up @@ -700,13 +628,11 @@ impl<S: SpartanExtensionField> PolyEvalProof<S> {
poly_list: &Vec<&DensePolynomial<S>>,
num_proofs_list: &Vec<usize>,
num_inputs_list: &Vec<usize>,
blinds_opt: Option<&PolyCommitmentBlinds<S>>,
rq: &[S],
ry: &[S],
Zr_list: &Vec<S>,
blind_Zr_opt: Option<&S>,
transcript: &mut Transcript,
random_tape: &mut RandomTape<S>,
_random_tape: &mut RandomTape<S>,
) -> Vec<PolyEvalProof<S>> {
<Transcript as ProofTranscript<S>>::append_protocol_name(
transcript,
Expand Down Expand Up @@ -771,32 +697,8 @@ impl<S: SpartanExtensionField> PolyEvalProof<S> {
}

let mut proof_list = Vec::new();

for i in 0..LZ_list.len() {
let L = &L_list[i];
let L_size = L.len();
let default_blinds = PolyCommitmentBlinds {
blinds: vec![S::field_zero(); L_size],
};
let blinds = blinds_opt.map_or(&default_blinds, |p| p);

assert_eq!(blinds.blinds.len(), L_size);

let blind_Zr = blind_Zr_opt.map_or(&zero, |p| p);
let LZ_blind: S = (0..L.len()).map(|i| blinds.blinds[i] * L[i]).sum();

// a dot product proof of size R_size
let proof = DotProductProofLog::prove(
transcript,
random_tape,
&LZ_list[i],
&LZ_blind,
&R_list[i],
&Zc_list[i],
blind_Zr,
);

proof_list.push(PolyEvalProof { proof });
for v in LZ_list.into_iter() {
proof_list.push(PolyEvalProof { v });
}

proof_list
Expand Down Expand Up @@ -871,7 +773,7 @@ impl<S: SpartanExtensionField> PolyEvalProof<S> {
for i in 0..LZ_list.len() {
let R = &R_list[i];

proof_list[i].proof.verify(R.len(), transcript, R)?;
proof_list[i].verify(transcript, R)?;
}

Ok(())
Expand All @@ -883,7 +785,7 @@ impl<S: SpartanExtensionField> PolyEvalProof<S> {
r: &S, // point at which the polynomial is evaluated
Zr: &Vec<S>, // evaluation of \widetilde{Z}(r)
transcript: &mut Transcript,
random_tape: &mut RandomTape<S>,
_random_tape: &mut RandomTape<S>,
) -> PolyEvalProof<S> {
<Transcript as ProofTranscript<S>>::append_protocol_name(
transcript,
Expand All @@ -904,7 +806,7 @@ impl<S: SpartanExtensionField> PolyEvalProof<S> {
let R_size = right_num_vars.pow2();

// compute R = <1, r, r^2, ...>
let R = {
let _R = {
let mut r_base = S::field_one();
let mut R = Vec::new();
for _ in 0..R_size {
Expand Down Expand Up @@ -951,18 +853,7 @@ impl<S: SpartanExtensionField> PolyEvalProof<S> {
c = c * c_base;
}

// a dot product proof of size R_size
let proof = DotProductProofLog::prove(
transcript,
random_tape,
&LZ_comb,
&zero,
&R,
&Zr_comb,
&zero,
);

PolyEvalProof { proof }
PolyEvalProof { v: LZ_comb }
}

pub fn verify_uni_batched_instances(
Expand Down Expand Up @@ -1021,7 +912,7 @@ impl<S: SpartanExtensionField> PolyEvalProof<S> {
c = c * c_base;
}

self.proof.verify(R.len(), transcript, &R)
self.verify(transcript, &R)
}
}

Expand Down Expand Up @@ -1049,7 +940,7 @@ mod tests {
.collect::<Vec<Scalar>>();

// compute dot product between LZ and R
DotProductProofLog::compute_dotproduct(&LZ, &R)
DensePolynomial::compute_dotproduct(&LZ, &R)
}

#[test]
Expand Down
Loading