Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

na_color stopped working in render_shapes() #83

Closed
LucaMarconato opened this issue Jun 5, 2023 · 0 comments · Fixed by #87
Closed

na_color stopped working in render_shapes() #83

LucaMarconato opened this issue Jun 5, 2023 · 0 comments · Fixed by #87
Assignees
Labels
bug Something isn't working

Comments

@LucaMarconato
Copy link
Member

LucaMarconato commented Jun 5, 2023

Sorry not making a MWE because I don't want to break the flow in fixing another bug.

In this example: #82 the gray squares and gray circles should have actually color na_color=(1.0, 0.7, 0.7, 0.5) which should be a semi-transparent reddish color:

image

edit by ttreis:

MRE

import matplotlib.pyplot as plt
import spatialdata as sd
import spatialdata_plot

blob = sd.datasets.blobs()

# otherwise pre-commits will remove the "unused" import
_ = spatialdata_plot

ax = plt.gca()
blob.pl.render_shapes(element="blobs_shapes", na_color=(1.0, 0.7, 0.7, 0.5)).pl.show(ax=ax)
plt.show()
image
@timtreis timtreis linked a pull request Jun 8, 2023 that will close this issue
@timtreis timtreis self-assigned this Jun 8, 2023
@timtreis timtreis added the bug Something isn't working label Jun 8, 2023
@timtreis timtreis closed this as completed Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants