Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistency in parameter filter_by_coordinate_system #433

Closed
melonora opened this issue Jan 17, 2024 · 1 comment · Fixed by #455
Closed

Inconsistency in parameter filter_by_coordinate_system #433

melonora opened this issue Jan 17, 2024 · 1 comment · Fixed by #455
Labels
invalid This doesn't seem right

Comments

@melonora
Copy link
Collaborator

When refactoring some code for #410 I noticed that there is an inconsistency in the parameters. In filter_by_coordinate_system we pass on element_paths_in_coordinate_system to _filter_table_by_coordinate_system. However, looking at this function the argument here refers to coordinate_system.
@melonora melonora added the invalid This doesn't seem right label Jan 17, 2024
@LucaMarconato
Copy link
Member

LucaMarconato commented Jan 17, 2024 •
edited
Loading

Well spotted, the argument of _filter_table_by_coordinate_system() (and the function name), should be renamed.

@LucaMarconato LucaMarconato linked a pull request Feb 22, 2024 that will close this issue
multi table support #455
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

multi table support scverse/spatialdata
2 participants
@LucaMarconato @melonora