Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add_table() method would be consistent w. other add_[attribute]() #451

Closed
MichielVerCruysse opened this issue Feb 6, 2024 · 1 comment · Fixed by #455
Closed

add_table() method would be consistent w. other add_[attribute]() #451

MichielVerCruysse opened this issue Feb 6, 2024 · 1 comment · Fixed by #455

Comments

@MichielVerCruysse
Copy link

Adding a table as follows
sdata.table = myTable
is inconsistent with the method for adding images, labels, points and shapes. I feel like an add_table method would be clearer.

@MichielVerCruysse MichielVerCruysse changed the title add_table method would be consistent w. other add_[attribute] add_table() method would be consistent w. other add_[attribute]() Feb 6, 2024
@LucaMarconato
Copy link
Member

Thanks @MichielVerCruysse for reporting this. We actually fixed this inconsistency but we haven't made a release yet. It will probably take a few more weeks until we cut one.

We took another approach: in #329 we remove the add_image(), add_labels(), ... methods and in the branch https://github.com/scverse/spatialdata/tree/multi_table we added support for multiple tables.

If you want you can already use these functions by installing the library from main or from the multi_table branch.

@LucaMarconato LucaMarconato linked a pull request Feb 22, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants