-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
polygon_query() support for images #358
Conversation
Hey @LucaMarconato. thanks for the PR!. looks like the failing test is related. Please ping me when you've fixed it and I can review. |
Fixed now, thanks for the review. This is also a linked pr, can you also review that please? https://github.com/scverse/spatialdata-notebooks/pull/51/files |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #358 +/- ##
=======================================
Coverage 90.57% 90.57%
=======================================
Files 36 36
Lines 4678 4692 +14
=======================================
+ Hits 4237 4250 +13
- Misses 441 442 +1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks!
I already approved this PR a couple of days ago. Is there something else you need feedback on? |
Small PR, needed for the paper.