Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

polygon_query() support for images #358

Merged
merged 3 commits into from
Sep 24, 2023

Conversation

LucaMarconato
Copy link
Member

Small PR, needed for the paper.

@kevinyamauchi
Copy link
Collaborator

Hey @LucaMarconato. thanks for the PR!. looks like the failing test is related. Please ping me when you've fixed it and I can review.

@LucaMarconato
Copy link
Member Author

LucaMarconato commented Sep 20, 2023

Fixed now, thanks for the review. This is also a linked pr, can you also review that please? https://github.com/scverse/spatialdata-notebooks/pull/51/files

@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Merging #358 (232165e) into main (054a7bf) will increase coverage by 0.00%.
Report is 7 commits behind head on main.
The diff coverage is 83.33%.

❗ Current head 232165e differs from pull request most recent head 69134e4. Consider uploading reports for the commit 69134e4 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #358   +/-   ##
=======================================
  Coverage   90.57%   90.57%           
=======================================
  Files          36       36           
  Lines        4678     4692   +14     
=======================================
+ Hits         4237     4250   +13     
- Misses        441      442    +1     
Files Changed Coverage Δ
src/spatialdata/_core/query/spatial_query.py 91.92% <83.33%> (+0.04%) ⬆️

Copy link
Collaborator

@kevinyamauchi kevinyamauchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

src/spatialdata/_core/query/spatial_query.py Outdated Show resolved Hide resolved
@kevinyamauchi
Copy link
Collaborator

Fixed now, thanks for the review. This is also a linked pr, can you also review that please? https://github.com/scverse/spatialdata-notebooks/pull/51/files

I already approved this PR a couple of days ago. Is there something else you need feedback on?

@LucaMarconato LucaMarconato merged commit 572136f into main Sep 24, 2023
4 checks passed
@LucaMarconato LucaMarconato deleted the feature/polygon_query_for_images branch September 24, 2023 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants