Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tests): increases delays in pkg/cloudmeta unit tests. #4175

Merged
merged 1 commit into from
Dec 17, 2024
Merged

fix(tests): increases delays in pkg/cloudmeta unit tests. #4175

merged 1 commit into from
Dec 17, 2024

Conversation

VAveryanov8
Copy link
Collaborator

This increases delay between 'fast' and 'slow' providers in metadata unit tests to reduce chance of failure.

Fixes: #4173

Please make sure that:

  • Code is split to commits that address a single change
  • Commit messages are informative
  • Commit titles have module prefix
  • Commit titles have issue nr. suffix

@VAveryanov8
fix(tests): increases delays in pkg/cloudmeta unit tests.
d215f40 
This increases delay between 'fast' and 'slow' providers in metadata
unit tests to reduce chance of failure.

Fixes: #4173
@VAveryanov8
Copy link
Collaborator Author

Seems like TestPurgeIntegration is flaky as well

--- Then: there should be 3 + 4 manifests
    service_backup_integration_test.go:1565: Expected 7 manifests (1 per each node) plus 4 generated, got 8 backup/meta/cluster/aa3bd91b-35d3-48e7-a0ee-7c4fc56996b1/dc/dc1/node/04b34d6d-efe9-4ed6-b19a-76e12cd0ac55/task_2e4e674d-977b-417e-9bb1-8324fa7421b7_tag_sm_20241220120743UTC_manifest.json.gz
        backup/meta/cluster/aa3bd91b-35d3-48e7-a0ee-7c4fc56996b1/dc/dc1/node/04b34d6d-efe9-4ed6-b19a-76e12cd0ac55/task_e960c937-d997-4043-9a2f-c75073d5f95f_tag_sm_20241216100743UTC_manifest.json.gz
        backup/meta/cluster/aa3bd91b-35d3-48e7-a0ee-7c4fc56996b1/dc/dc1/node/04b34d6d-efe9-4ed6-b19a-76e12cd0ac55/task_e960c937-d997-4043-9a2f-c75073d5f95f_tag_sm_20241217100743UTC_manifest.json.gz
        backup/meta/cluster/aa3bd91b-35d3-48e7-a0ee-7c4fc56996b1/dc/dc1/node/04b34d6d-efe9-4ed6-b19a-76e12cd0ac55/task_ee4153d4-fa91-4f76-bc2a-6821452eeba2_tag_sm_20241216120743UTC_manifest.json.gz
        backup/meta/cluster/aa3bd91b-35d3-48e7-a0ee-7c4fc56996b1/dc/dc1/node/04b34d6d-efe9-4ed6-b19a-76e12cd0ac55/task_f33d1d49-da25-4715-b0e0-d787ebf4dfde_tag_sm_20241217120743UTC_manifest.json.gz
        backup/meta/cluster/aa3bd91b-35d3-48e7-a0ee-7c4fc56996b1/dc/dc1/node/360fe131-e59b-46d9-acd3-4730947499ab/task_f33d1d49-da25-4715-b0e0-d787ebf4dfde_tag_sm_20241217120743UTC_manifest.json.gz
        backup/meta/cluster/aa3bd91b-35d3-48e7-a0ee-7c4fc56996b1/dc/dc1/node/ac764087-2004-4fa1-ba97-a3ca5bd22b30/task_f33d1d49-da25-4715-b0e0-d787ebf4dfde_tag_sm_20241217120743UTC_manifest.json.gz
        backup/meta/cluster/aa3bd91b-35d3-48e7-a0ee-7c4fc56996b1/dc/dc1/node/b5502919-fcb7-40d0-a066-caa98b12867e/task_f33d1d49-da25-4715-b0e0-d787ebf4dfde_tag_sm_20241217120743UTC_manifest.json.gz
--- FAIL: TestPurgeIntegration (7.63s)

@Michal-Leszczynski
Copy link
Collaborator

@VAveryanov8 please report the flakiness under #4172.

@VAveryanov8 VAveryanov8 mentioned this pull request Dec 17, 2024
Open
@VAveryanov8 VAveryanov8 marked this pull request as ready for review December 17, 2024 13:16
@VAveryanov8 VAveryanov8 merged commit 4e52b04 into master Dec 17, 2024
51 checks passed
@VAveryanov8 VAveryanov8 deleted the va/flaky-metadata-tests branch December 17, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Michal-Leszczynski Michal-Leszczynski Michal-Leszczynski approved these changes

@karol-kokoszka karol-kokoszka karol-kokoszka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flakiness in unit-test related to metadata
3 participants
@VAveryanov8 @Michal-Leszczynski @karol-kokoszka