Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'nodetool version' shows wrong version #45

Open
abvgedeika opened this issue Aug 1, 2017 · 3 comments
Open

'nodetool version' shows wrong version #45

abvgedeika opened this issue Aug 1, 2017 · 3 comments
Assignees
@denesb

Comments

@abvgedeika
Copy link

based on http://docs.scylladb.com/nodetool-commands/version/

Nodetool version

version - Print the DB version Example

nodetool version

but nodetool doesn't show the correct scylla version

[centos@ip-172-30-0-65 ~]$ nodetool version
ReleaseVersion: 3.0.8
[centos@ip-172-30-0-65 ~]$ rpm -qa| grep scylla
scylla-tools-core-2.0.rc1-20170730.8e1ef86.el7.centos.noarch
scylla-debuginfo-2.0.rc1-0.20170730.aaa59d3.el7.centos.x86_64
scylla-env-1.0-1.el7.centos.noarch
scylla-conf-2.0.rc1-0.20170730.aaa59d3.el7.centos.x86_64
scylla-tools-2.0.rc1-20170730.8e1ef86.el7.centos.noarch
scylla-server-2.0.rc1-0.20170730.aaa59d3.el7.centos.x86_64
scylla-2.0.rc1-0.20170730.aaa59d3.el7.centos.x86_64
scylla-gdb-7.10.1-30.el7.centos.x86_64
scylla-kernel-conf-2.0.rc1-0.20170730.aaa59d3.el7.centos.x86_64
scylla-jmx-2.0.rc1-20170730.3451d25.el7.centos.noarch
@penberg
Copy link
Contributor

penberg commented Aug 2, 2017

@abvgedeika nodetool version is showing the same Cassandra version ScyllaDB advertises to the CQL drivers. I think we can change it to query ScyllaDB version from the REST API via the JMX proxy and show that instead without breaking anything.

@mykaul
Copy link
Contributor

mykaul commented Mar 5, 2024

@denesb - let's ensure the native nodetool shows the correct version.

@denesb
Copy link
Contributor

denesb commented Mar 5, 2024

The version is returned by a Scylla API endpoint: /storage_service/release_version. If we change this, the legacy nodetool will also show the new version. Not a problem IMO, the version we currently print just confuses people, nobody thinks it is the version of a compatible C* release.

@denesb denesb self-assigned this Mar 5, 2024
denesb added a commit to denesb/scylla that referenced this issue Mar 15, 2024
@denesb
version: kill version::release()
cd21f8e 
This method returns an arbitrary version of Cassandra, we consider
ourselves most compatible with. At least that is the theory behind it,
but saw no update in years, so it is probably stale.
This method appears in the output of `nodetool version`, in the
system.versions virtual table, among others. It is even gossiped around
and stored in topology metadata for some reason.
It is a regular source of confusion as users and even developers confuse
it with the real scylla version. To end the confusion, kill
version::release(), replacing all its usage with the version of ScyllaDB
proper.

Fixes: scylladb/scylla-tools-java#45
@denesb denesb mentioned this issue Mar 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@denesb denesb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

version: kill version::release() denesb/scylla
4 participants
@penberg @denesb @mykaul @abvgedeika