-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable use of 'unset' values in prepared statements by default #66
Comments
It would probably be good as the default option should be the one that performs better. I won't insist though :) |
@haaawk No, I think it's a reasonable requirement before defaulting to the new option. |
@penberg @elcallio I would wait with enabling this by default. I was testing sstable loader with data generated by cassandra stress. Default schema is: CREATE KEYSPACE keyspace1 WITH replication = {'class': 'SimpleStrategy', 'replication_factor': '1'} AND durable_writes = true; CREATE TABLE keyspace1.counter1 ( CREATE TABLE keyspace1.standard1 ( and running sstable loader like this: ./bin/sstableloader -u -d 127.0.0.1 /home/haaawk/.ccm/loader-1/node1/data0/keyspace1/standard1-c17511f0bb2111e8ac3f47eff2803657/ generates lots of errors: com.datastax.driver.core.exceptions.InvalidQueryException: Unknown identifier column1 |
We have support for the use of 'unset' values to reduce the number of prepared statements as of commit b432a08. However, user needs to explicitly enable that with the
-u
command line option, which they will easily forget to do.We should make this enabled by default just like we do for prepared statements and batching since commit b382110. @haaawk did want us to check the performance impact of 'unset' before we do that, though.
The text was updated successfully, but these errors were encountered: