Skip to content
This repository has been archived by the owner on May 14, 2024. It is now read-only.

Default argument value is mutable #332

Closed
Polyipnus opened this issue Oct 15, 2019 · 2 comments · May be fixed by #334
Closed

Default argument value is mutable #332

Polyipnus opened this issue Oct 15, 2019 · 2 comments · May be fixed by #334

Comments

@Polyipnus
Copy link

File: orator/utils/url.py
def translate_connect_args(self, names=[], **kw):

as function translate_connect_args defined in line 134, has a potential problem, which IDEs will complain with Default argument value is mutable.
@mandarvaze
Copy link

mandarvaze commented Nov 11, 2019 •
edited
Loading

  1. Comment says names is Deprecated.
  2. translate_connect_args itself does not seem to be used anywhere.

I wonder if the function itself can be removed all together.

I also noticed that comments in this file (orator/utils/url.py) reference SQLAlchemy. I wonder why ?

mandarvaze added a commit to mandarvaze/sdispater-orator that referenced this issue Nov 11, 2019
@mandarvaze
Remove unused code.
c0586a4 
Fix sdispater#332
@mandarvaze mandarvaze mentioned this issue Nov 11, 2019
Open
mandarvaze added a commit to MasoniteFramework/orator that referenced this issue Nov 15, 2019
@mandarvaze
🔥 Remove unused code
b4986be 
Fix sdispater#332
@Polyipnus
Copy link
Author

Polyipnus commented Jun 23, 2021 •
edited
Loading

  1. Comment says names is Deprecated.
  2. translate_connect_args itself does not seem to be used anywhere.

I wonder if the function itself can be removed all together.

I also noticed that comments in this file (orator/utils/url.py) reference SQLAlchemy. I wonder why ?

I will close this issue, thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove unused code. mandarvaze/sdispater-orator
2 participants
@mandarvaze @Polyipnus