Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composable transformers or allow for one-hotting of CBN components? #631

Open
HarrisonWilde opened this issue Apr 11, 2023 · 0 comments
Open
Labels
new Label applied to new issues

Comments

@HarrisonWilde
Copy link

Problem Description

Specifically, my question stems from wanting to one hot encode the component part of the result of applying the ClusterBasedNormalizer? My custom generator doesn't deal well with non-one-hotted categoricals and I'd like to change the HyperTransformer / underlying one in an SDV Synthesizer as little as possible? Currently I am defining a second HyperTransformer with OneHotEncoders for all the columns that use ClusterBasedNormalizer and None for all other columns but this is a little tedious / feels suboptimal as a workflow. Looking at the code for the ClusterBasedNormalizer it could make sense to expose a choice to the user as to how components is encoded? Alternatively, making transformers composable through some framework could be a nice addition to the package.

Expected behavior

One of:

  • cbn = ClusterBasedNormalizer(..., onehot = True, ...)
  • ht = HyperTransformer(); ht.update_transformers({"colname": [ClusterBasedNormalizer(...), OneHotEncoder()]}) o.e.
@HarrisonWilde HarrisonWilde added the new Label applied to new issues label Apr 11, 2023
@HarrisonWilde HarrisonWilde changed the title Composable transformers? Composable transformers or allow for one-hotting of CBN components? Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new Label applied to new issues
Projects
None yet
Development

No branches or pull requests

1 participant