Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Java 17 #138

Closed
wants to merge 1 commit into from
Closed

Conversation

fans2619
Copy link

@fans2619 fans2619 commented Jun 23, 2022

Fixes #137

@fans2619 fans2619 force-pushed the 137-upgrade-to-java-17 branch from 5026884 to e5bd984 Compare June 23, 2022 07:19
@fans2619 fans2619 force-pushed the 137-upgrade-to-java-17 branch from e5bd984 to bbbb168 Compare June 23, 2022 07:26
@fans2619
Copy link
Author

@damithc The app is runnable in Java 17 when simply changing the Java version in build.gradle and actually I don't see big problems.🤔 There are just some minor issues as pointed out by IDE and also in #122 . I'll look into those later.

image

@damithc
Copy link
Contributor

damithc commented Jun 23, 2022

@fans2619 That's good news. We also want to make sure relevant guides at https://se-education.org/guides/ are compatible with Java 17. e.g., JUnit tutorial JavaFX tutorial

We also need to decide if we should transition the project to use Java modules

@se-edu/tech-team-level1 What do you guys think?

@damithc
Copy link
Contributor

damithc commented May 9, 2023

Putting this hold for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to Java 17
2 participants