Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: What about configure gridColumns per Container? #112

Open
samsonovkirill opened this issue Sep 19, 2019 · 0 comments
Open

Suggestion: What about configure gridColumns per Container? #112

samsonovkirill opened this issue Sep 19, 2019 · 0 comments

Comments

@samsonovkirill
Copy link

samsonovkirill commented Sep 19, 2019

Sometimes it's convenient to change gridColumns value on Container rather then per project globally, if it make sense I have a small solution of this problem based on the same idea with a gutter context but Provider is created on Container level and consumes gridColumn on Column level, if there is no gridColumn prop specified in Container the default value from config is applied.
Example:

<Container fluid style={{ lineHeight: '32px' }} gridColumns={13}>
  <Row debug>
    <Col lg={7} debug>1 of 2</Col>
    <Col lg={6} debug>2 of 2</Col>
  </Row>
</Container>

Row consumes value from nearest Container Provider. I've created a PR #113

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant