Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing font awesome resources #241

Open
AdamPirany opened this issue Nov 5, 2020 · 2 comments
Open

Fix missing font awesome resources #241

AdamPirany opened this issue Nov 5, 2020 · 2 comments

Comments

@AdamPirany
Copy link

AdamPirany commented Nov 5, 2020

I try to implement the modal fold-out component
https://designlibrary.sebank.se/components/component-foldout

but it seems to be missing in the modal component.
Any idea when this can be done ?

Regards

@AdamPirany AdamPirany changed the title Where is the modal-foldout in modal component? Where is the modal fold-out in modal component? Nov 5, 2020
@splashdust
Copy link
Contributor

Here it is:
https://sebgroup.github.io/vanilla-pattern-library/#components/modals/modal-foldout

There seem to be an issue with Font Awesome icons at the moment, so you need to click on "Show details" and select "Expanded state" to see it (because base state only shows the ellipsis icon)

One thing to note is that the fold-out is not implemented as a separate component here, but instead uses the drop down component. Thus it doesn't have its own class name.

@Maximilian-R Maximilian-R changed the title Where is the modal fold-out in modal component? Fix missing font awesome resources Dec 17, 2020
@Maximilian-R
Copy link
Collaborator

The font awesome resources in preview mode are pointing to https://designlibrary.sebgroup.com/static/Fonts/fontawesome/* which is empty. Perhaps the resources was removed along with the launch of the new DL site (that uses the font awesome npm package instead)? Should we include them in this project? Should we make us of a cdn instead, like the bootstrap project? Lets discuss after holidays! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants