Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable add-on to be translated, locale folder and subfolders required #2

Open
ovari opened this issue Apr 17, 2019 · 10 comments
Open
Assignees
Labels
enhancement New feature or request

Comments

@ovari
Copy link

ovari commented Apr 17, 2019

Enable add-on to be translated.

For example:
https://github.com/sebastianha/sfoa/blob/master/src/chrome/content/sfoa.xul#L6
<toolbarbutton removable="true" id="outlook-appointment-button" class="toolbarbutton-1 msgHeaderView-button" label="Download ICS" tooltiptext="Download attached Outlook appointment" style="display: none; background-color: #0071c5; color: white; list-style-image: url('chrome://sfoa/content/outlook-appointment-button.svg');"/>

chrome/locale/en-US/someFileName.ext
tooltiptext="Download attached Outlook appointment"

https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Coding_Style

What are your thoughts?

Thank you

@sebastianha
Copy link
Owner

Hi,
good idea, I was not expecting that much of a response to my addon, As soon as I find some time, I will prepare some updates.
Thanks for the suggestion!

@sebastianha sebastianha self-assigned this Apr 18, 2019
@sebastianha sebastianha added the enhancement New feature or request label Apr 18, 2019
@ovari ovari mentioned this issue Apr 18, 2019
@ovari
Copy link
Author

ovari commented Sep 30, 2019

@sebastianha can you advise when you can accept our merge? Thank you

@sebastianha
Copy link
Owner

Hi,
could you successfully test the patch on your system? Can you post a screenshot with the translated plugin?
Regards, Sebastian

@ovari
Copy link
Author

ovari commented Sep 30, 2019

Hi Sebastian,

We updated the files using GitHub's Web Editor. Unfortunately, we don't know how to produce an xpi file that we can then test. Can you please advise how we can get an xpi file?

Thank you

@sebastianha
Copy link
Owner

There is Makefile which builds the xpi

@ovari
Copy link
Author

ovari commented Sep 30, 2019

Does GitHub create the xpi file in our locale fork?

Can you please write how to use the Makefile on the README.md?

Thank you

@sebastianha
Copy link
Owner

Just run "make"

@ovari
Copy link
Author

ovari commented Sep 30, 2019

How does one run "make" using the web browser?

@sebastianha
Copy link
Owner

Please google how to use Makefiles or how to build the XPI. I am sorry but I am too busy right now to test the pull request.

@ovari
Copy link
Author

ovari commented Sep 30, 2019

Download and rename the sfoa.zip file to sfoa.xpi

Screenshot
kép

If you want to send an email to our email address with an ICS attachment, we can send you a screenshot with ICS.

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants