Fix payload_len calculation for DataPacket.
#4545
Open
+102
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4545 +/- ##
==========================================
- Coverage 81.61% 78.71% -2.91%
==========================================
Files 356 331 -25
Lines 85545 80350 -5195
==========================================
- Hits 69819 63246 -6573
- Misses 15726 17104 +1378
|
Splinter1984
force-pushed
the
fix_data_packet_pl_len
branch
from
c0193ed
to
d87ccc8
Compare
Take into account size of `inlineQoS`.
Splinter1984
force-pushed
the
fix_data_packet_pl_len
branch
from
d87ccc8
to
06aeab2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix
pl_lencalculation issue for DataPacket of RTPS protocol.Take into account the size of
inlineQoSduringpayloadlength calculation.Closes #4594