Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about importer behaviour where Blank values in location:name are blank #784

Open
tlongers opened this issue Oct 14, 2021 · 0 comments

Comments

@tlongers
Copy link
Member

tlongers commented Oct 14, 2021

In cases where OpenStreetMap is our geospatial source (which you can see where location:origin IS "osm"), the field field location:name is synced through the Overpass API to the OSM object name. In some cases, objects gulped in from this route will:

  • not have a name, and Overpass with return a none value; or,
  • have a name that we don't want to use, because our research shows it's wrong.

In both cases, we can override the value in location:name using the first part of the "humane id" format. For example:

location:humane_id:admin location:name
Location McLocation (osm, point) that uuid [null value / none value]
Namey McName Face (osm, poly) this uuid Wrong Name We Don't Like

How does the importer currently deal with situations like these where there is a deliberate internal inconsistency?

I'm considering adding a field to make the location names we substitute in these cases an explicit value, but wanted to know what our current situation is.

@tlongers tlongers changed the title Quesiton about importer behaviour where Blank values in location:name Quesiton about importer behaviour where Blank values in location:name are blank Oct 14, 2021
@tlongers tlongers changed the title Quesiton about importer behaviour where Blank values in location:name are blank Question about importer behaviour where Blank values in location:name are blank Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant