Add initial tally params to genesis #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thomasvdam
force-pushed
the
feat/planet-tally-genesis
branch
from
f545389 to
c3c7845
Compare
hacheigriega
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The latest version of planet expects a default value for the max tally gas to have been set at genesis.
Explanation of Changes
N.A.
Testing
Check out the latest main from the SEDA chain and join planet:
$BIN join party --network planetBefore starting the node edit the genesis to match the changes in this PR. Set a breakpoint in the init genesis function of the tally module. When you start the chain in debug mode you should see that the correct value is set. Continuing won't work since the state hash differs from the latest deployment, but it shows that the change works as expected.
The genesis files on the validators have already been updated in preparation of a reset later this week.
Related PRs and Issues
N.A.