Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testspec: Valgrind CT::poison() overview #255

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Testspec: Valgrind CT::poison() overview #255

wants to merge 2 commits into from

Conversation

reneme
Copy link
Collaborator

@reneme reneme commented Oct 28, 2024 •
edited
Loading

Closes #231

@reneme reneme added this to the Botan 3.6.1 milestone Oct 28, 2024
@reneme reneme self-assigned this Oct 28, 2024
@reneme reneme marked this pull request as draft October 28, 2024 14:20
@reneme reneme marked this pull request as ready for review October 29, 2024 13:30
@reneme reneme changed the title WIP: Testspec: Valgrind CT::poison() overview Testspec: Valgrind CT::poison() overview Oct 29, 2024
@reneme reneme mentioned this pull request Oct 29, 2024
Draft
FAlbertDev
FAlbertDev approved these changes Oct 30, 2024
View reviewed changes
Copy link
Collaborator

@FAlbertDev FAlbertDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I like this description. Especially the example gives a good intuition about Valgrind. I left some comments, mainly to make my Grammarly license worth it.

docs/testspec/src/90_valgrind_sca.rst Outdated Show resolved Hide resolved
docs/testspec/src/90_valgrind_sca.rst Outdated Show resolved Hide resolved
docs/testspec/src/90_valgrind_sca.rst Outdated Show resolved Hide resolved
docs/testspec/src/90_valgrind_sca.rst Outdated Show resolved Hide resolved
docs/testspec/src/90_valgrind_sca.rst
* **Results are not easily generalizable**

Valgrind detects secret-dependent execution patterns in a specific binary
that was generated with certain compiler flags and for a concrete hardware
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
that was generated with certain compiler flags and for a concrete hardware
that was generated with certain compiler flags and for concrete hardware

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I disagree here. The point is that it is "one specific concrete hardware", no?

Copy link
Collaborator

@FAlbertDev FAlbertDev Oct 30, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, the phase continues in the next line:
... and for [a] concrete hardware platform.

docs/testspec/src/90_valgrind_sca.rst Show resolved Hide resolved
docs/testspec/src/90_valgrind_sca.rst Show resolved Hide resolved
@reneme @FAlbertDev
Review comments
dfb24e7 
Co-Authored-By: Fabian Albert <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FAlbertDev FAlbertDev FAlbertDev approved these changes

@sehlen-bsi sehlen-bsi Awaiting requested review from sehlen-bsi

@weitkaemper-bsi weitkaemper-bsi Awaiting requested review from weitkaemper-bsi

Assignees

@reneme reneme

Labels
side channel report testspec
Projects
None yet
Milestone
Botan 3.6.1
Development

Successfully merging this pull request may close these issues.

Mention the valgrind Side Channel Analysis
2 participants
@reneme @FAlbertDev