Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[closeCloser] false positive in loki #34

Open
seiyab opened this issue Apr 16, 2024 · 0 comments
Open

[closeCloser] false positive in loki #34

seiyab opened this issue Apr 16, 2024 · 0 comments

Comments

@seiyab
Copy link
Owner

seiyab commented Apr 16, 2024

userBucket here is derived from b.bucket. Shouldn't close it.
https://github.com/grafana/loki/blob/397aa56e157cbf733da548474a4bcae773e82362/pkg/ruler/rulestore/bucketclient/bucket_client.go#L54-L56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant