Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge SPARQL functionality #65

Open
LukasBluebaum opened this issue Sep 17, 2019 · 2 comments
Open

Merge SPARQL functionality #65

LukasBluebaum opened this issue Sep 17, 2019 · 2 comments

Comments

@LukasBluebaum
Copy link
Collaborator

In qa.commons, there are 2 different ways to fire queries to an endpoint, SPARQL and SPARQLExecutor. This becomes tedious to keep clean, especially when both share the same (hardcopied) code.
Consider merging the functionality in favor of SPARQL.
@RicardoUsbeck
Copy link
Member

Makes sense.
@Aklakan as an expert, do you have any recommendation which to keep?

@LukasBluebaum
Copy link
Collaborator Author

There was already a TODO in the code that SPARQL should be kept. I guess thats because it also supports caching and the other one doesn't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@RicardoUsbeck @LukasBluebaum