@semaphore-protocol/data uses utility functions that can be replaced by @zk-kit/utils

[cedoor]

Description

@semaphore-protocol/data uses checkParameters to check if the parameter types are the correct ones. Since there's already a @zk-kit/utils dependency, it could use the zk-kit utility error-handlers functions directly, and avoid duplicating code.

[jancris100]

Can you assign this to me please?

[vplasencia]

Hey @jancris100 sure. I just assigned you this issue. Please, let us know if you have questions.

[hannahredler]

Hey! I'm Hannah, a developer studying with the PSE Core program :) If this isn't in progress already I would be happy to take it on. @vplasencia @jancris100

[cedoor]

Hey @hannahredler, there's already a PR for this issue. Let's try to ping the author and ask them first.

@jancris100 there are some issues to solve in your PR: #782. Let us know if you've time to work on it. Otherwise no problem, just a double-check before re-assigning the issue.

[jancris100]

This issue i already finish it a long time ago

[cedoor]

@jancris100 great! Could you reply to my comments there? Some conflicts also need to be resolved.

[Chirag-S-Kotian]

@jancris100 then why this pr is not closed

[cedoor]

Hi @Chirag-S-Kotian, the PR has been closed as there has not been activity for a while.

The issue is open again to anyone who wants to contribute.

We give contributors ample time to work on good first issues as they are not a priority. However, please consider we need to set a time limit of a few months to prevent the codebase/PRs from becoming stagnant/outdated.

[0xshikhar]

Hey @cedoor , would like to work on this task - can you assign me that. Any additional context would be appreciated. Thanks!