Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upcoming changes in run-command #3

Open
bard opened this issue Jan 12, 2023 · 4 comments
Open

Upcoming changes in run-command #3

bard opened this issue Jan 12, 2023 · 4 comments

Comments

@bard
Copy link

bard commented Jan 12, 2023

Thought I'd give you a heads-up about changes in the next version of run-command, as they might impact compatibility with this collection.

  • Recipes will support an optional :runner property pointing to runner function; the runner function configures the buffer where the command runs to (among other things) select the major mode, such as term-mode, compilation-mode etc. When the recipe doesn't have a :runner property, the value of the run-command-default-runner variable is used instead.

  • There will be no run-command--run-compile, run-command--run-term, and run-command--run-vterm functions anymore. (As you might know, functions and variables prefixed with double hyphen are considered internals and can change or disappear at any time.)

  • The "lisp function" experiment will almost certainly be retired.

  • Finally, some of the recipes currently featured as examples might become part of the package; there may be overlap but there should be no danger of name conflict. (Initially I considered pointing to this package, but the implementations here seem quite a bit heavier on code than how I originally envisioned recipes, as lightweight and mostly data, to allow understanding and hacking by people who know little elisp.)

@bard
Copy link
Author

bard commented Jan 22, 2023

Some documentation about the next version is up: https://bard.github.io/emacs-run-command

@semenInRussia
Copy link
Owner

I will try remove usages of the internal functions and make code of the recipes more easily where can, but most of the recipes from this repo couldn't be more easily, so think the cookbook from your repo is an awesome idea! and link to this repo is superfluous.

Thanks for last changes, i think it cool!

@semenInRussia
Copy link
Owner

  • Ye. I start use keywords :runner and :hook instead of my
    crutches in the last commits
  • Usages of the internal functions of run-command is in the past in
    this repo
  • "lisp function" now isn't adding after installation
  • Name conflicts with your built-in recipes wont't happened, because I
    use for each recipe prefix run-command-recipes-, you use
    run-command-recipe- (without s)

if you think, that I closed the your remarks, then close this issue

Good Luck!

@bard
Copy link
Author

bard commented Jan 28, 2023

I guess so, but only had a quick glance, so it's up to you.

One thing you might want to keep in mind is that one of the term modes (either term.el or eat.el) will become the default on *nix platforms, so perhaps you don't need to specify it with :runner. The other is that specifying it might actually break things for Windows users, since term modes don't work there (run-command will default to compilation-mode).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants