Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for raw podcast description #352

Closed
wants to merge 1 commit into from

Conversation

archekb
Copy link
Contributor

@archekb archekb commented Aug 15, 2023

issue #349

@brian-doherty
Copy link
Contributor

Cool by me. I think "RAW" should be changed to "Raw" for stylistic reasons since it's not an acronym.

@sentriz
Copy link
Owner

sentriz commented Aug 15, 2023

i'm a little bit hesitant here since we don't know of any subsonic clients that support html, and a like to have as few config options as possible

i know there is tamland/airsonic-refix#110 but we could wait until it's merged? at least then we would have one client to set a standard of sorts

or see if @opensubsonic would support a protocol to negotiate description text formats?

@tamland
Copy link

tamland commented Aug 20, 2023

Also hesitant about this as it can completely break client layout when tags such as hX, div and other are allowed. Also there's the never ending security issues with sanitization (case in point tamland/airsonic-refix#110 contains the target="_blank" vulnerability)

Maybe if the html was limited to only tags that won't cause layout issues, but I'm not sure what that would be.

@archekb
Copy link
Contributor Author

archekb commented Aug 20, 2023

Come on... Security problems ... sounds scared, but I don't think so it can be problem and this is can be fixed by adding attribute rel="noopener noreferrer". Only h5 and h6 allowed, I can remove it, it's not a problem... We can create very conservative default option, but allow to users change it in client settings later.

PS

Update as of 2021: All current versions of major browsers now automatically use the behavior of rel="noopener" for any target="_blank" link, nullifying this issue. See more at chromestatus.com.

@sentriz sentriz added this to the v0.16.0 milestone Aug 31, 2023
@sentriz sentriz removed this from the v0.16.0 milestone Aug 31, 2023
@archekb
Copy link
Contributor Author

archekb commented Sep 3, 2023

@sentriz I make a fork of airsonic-refix, it's named xonic-ui (https://github.com/archekb/xonic-ui), this client support this feature.

@sentriz
Copy link
Owner

sentriz commented Sep 20, 2023

hey thanks for the effort here but closing for now until it's a supported feature from @opensubsonic . (xonic-ui is the only client that supports this right)

feel free to re open then

PS will check out the share feature soon 👍

@sentriz sentriz closed this Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants