Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing profilingFunctionsConsumer.sidecars #1627

Merged
merged 2 commits into from
Dec 11, 2024
+6 −4
Merged

fix: missing profilingFunctionsConsumer.sidecars #1627

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
069f166
fix: wip
ServerSideHannes Dec 9, 2024
6715248
fix: wip
ServerSideHannes Dec 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions charts/sentry/templates/snuba/deployment-snuba-profiling-functions-consumer.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,8 +160,8 @@ spec:
securityContext:
{{ toYaml .Values.snuba.profilingFunctionsConsumer.containerSecurityContext | indent 12 }}
{{- end }}
{{- if .Values.profilingFunctionsConsumer.sidecars }}
{{ toYaml .Values.profilingFunctionsConsumer.sidecars | indent 6 }}
{{- if .Values.snuba.profilingFunctionsConsumer.sidecars }}
{{ toYaml .Values.snuba.profilingFunctionsConsumer.sidecars | indent 6 }}
{{- end }}
{{- if .Values.global.sidecars }}
{{ toYaml .Values.global.sidecars | indent 6 }}
Expand Down
4 changes: 2 additions & 2 deletions charts/sentry/templates/snuba/deployment-snuba-profiling-profiles-consumer.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,8 +160,8 @@ spec:
securityContext:
{{ toYaml .Values.snuba.profilingProfilesConsumer.containerSecurityContext | indent 12 }}
{{- end }}
{{- if .Values.profilingFunctionsConsumer.sidecars }}
{{ toYaml .Values.profilingFunctionsConsumer.sidecars | indent 6 }}
{{- if .Values.snuba.profilingFunctionsConsumer.sidecars }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ServerSideHannes please correct profilingFunctionsConsumer to profilingProfilesConsumer for this file

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And please add default commented values # sidecars: [] for profilingFunctionsConsumer and profilingFunctionsConsumer to values.yaml

{{ toYaml .Values.snuba.profilingFunctionsConsumer.sidecars | indent 6 }}
{{- end }}
{{- if .Values.global.sidecars }}
{{ toYaml .Values.global.sidecars | indent 6 }}
Expand Down
Loading