-
Notifications
You must be signed in to change notification settings - Fork 82
Github Review Process
Lydia Buntrock edited this page Oct 18, 2021
·
1 revision
The workflow for a new PR is as follows:
- create it with a nice description and a connection to its issue (
Resolves #NUMBER_OF_ISSUE
orpart of #NUMBER_OF_ISSUE
) - select as reviewers: seqan/team which selects the "1. Reviewer" from our team
-
review by first reviewer
- incorporate requested changes
- re-request first reviewer if he/she didn't approve (loop 3. until approve)
- select the second reviewer: seqan/core which selects the "2. Reviewer" from our team
-
review by second reviewer
- incorporate requested changes
- re-request second reviewer if he/she didn't approve (loop 5. until approve)
- tidy up Commit History if necessary
- get merged by core team