Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimizations prevent reusing translations on existing unmodified files #127

Open
iafan opened this issue Mar 4, 2020 · 0 comments
Open

Comments

@iafan
Copy link
Contributor

iafan commented Mar 4, 2020

Current optimization logic (https://github.com/evernote/serge/blob/4fde09810df74305f3ba33f94986cb209f1ba05d/lib/Serge/Engine.pm#L1202-L1206) doesn't account for the fact that the TS files for language may need to be rebuilt if there are new potentially reusable strings in the database for that language.

Right now strings will be reused only when there's another event that will trigger the update: source or TS file is changed, or were just created, or target file is removed.

When translations reuse feature is enabled on a job, an extra check needs to be done (for example, a highest usn of the language needs to be compared, or file cache needs to be analyzed).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant