-
The PR #57 suggests adding this var. Is it beneficial for the project? |
Beta Was this translation helpful? Give feedback.
Replies: 1 comment 1 reply
-
I think this is absolutely fine, however, since there is nothing to compile, only tests and examples, and those should be disabled when you package the library, it has no effect for the cmake install, or, if you build a package. For the real compilation of elfio it will be used with what ever the cpp file of the user will be compiled with, and this will be very likely c++11, 14 , 17, or soon 20 So it might be a good idea to make that value configurable, so you can build and run the tests with any C++ standard you want cmake to configure with, and if non is given, fall back to 11. |
Beta Was this translation helpful? Give feedback.
I think this is absolutely fine,
however, since there is nothing to compile, only tests and examples, and those should be disabled when you package the library, it has no effect for the cmake install, or, if you build a package.
For the real compilation of elfio it will be used with what ever the cpp file of the user will be compiled with, and this will be very likely c++11, 14 , 17, or soon 20
So it might be a good idea to make that value configurable, so you can build and run the tests with any C++ standard you want cmake to configure with, and if non is given, fall back to 11.
Than it is easy to test that you do not use anything that was deprecated / disabled in a standard