Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moss + boulder: Streamline version info commands/options/flags #233

Open
ermo opened this issue May 6, 2024 · 0 comments
Open

moss + boulder: Streamline version info commands/options/flags #233

ermo opened this issue May 6, 2024 · 0 comments
Labels
type: bug Something isn't working. type: enhancement New feature or request

Comments

@ermo
Copy link
Member

ermo commented May 6, 2024

Proposal

Enable version, -V and --version as the supported arguments, so we increase the likelihood for people to get a match if they're looking for version info. Note that rustc supports --version and -V, so supporting these argument is part and parcel in the ecosystem.

Additionally, make moss and boulder print out version information as # <executable> version (git hash) if an invocation contains commands in addition to -V/--version, such as boulder --version build or moss --version install (...).

This will enable infrastructure tooling to always call moss and boulder with the --version argument, which is a benefit when checking logs for which versions were used build/install packages, which in turn means that operationally, canary builds will also serve as a way to ensure that the deployed versions are the ones that we expected to be deployed.

Context

Currently, moss and boulder don't support the same arguments when trying to get version info:

$ moss -V
error: unexpected argument '-V' found

Usage: moss [OPTIONS] [COMMAND]

For more information, try '--help'.
$ moss -v
moss 0.1.0 (931a4f5)
$ moss --version
moss 0.1.0 (931a4f5)
$ moss version
moss 0.1.0 (931a4f5)

$ boulder -V
boulder 0.1.0 (931a4f5)
$ boulder -v
error: unrecognized subcommand 'version'

Usage: boulder [OPTIONS] <COMMAND>

For more information, try '--help'.
$ boulder --version
boulder 0.1.0 (931a4f5)
$ boulder version
error: unrecognized subcommand 'version'

Usage: boulder [OPTIONS] <COMMAND>

For more information, try '--help'.
@ermo ermo added the type: bug Something isn't working. label May 6, 2024
@ermo ermo added this to the oxide-prealpha1 milestone May 6, 2024
@ermo ermo added the type: enhancement New feature or request label May 6, 2024
@tarkah tarkah removed their assignment Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working. type: enhancement New feature or request
Projects
Development

No branches or pull requests

2 participants