-
-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to configure all cloudfront inputs #270
Comments
This would potentially solve #274 too |
@barrysteyn This sounds great 🔥Feel free to PR and I'll review. |
+1 this would be a great feature. I'm having the same issue with user-agent headers and would also like to disable caching for some code paths which such as /user-profile because if the page is rendered on the server then currently it will be cached and shown to other users. |
I just did it myself: #282. Confirmed it works on my own deployment. @danielcondemarin let me know what you think and i'll add some tests and update the docs. |
I've added tests and documentation. It looks like your remark markdown linter is broken. I dont think the issue its failing me for is valid |
Hi, I am going to give this one a crack over the weekend. I do note that #282 is doing something similar, but it's not 100% what I had in mind. |
hi, |
Sorry I forgot to close the issue. This has been merged already https://github.com/danielcondemarin/serverless-next.js/blob/master/packages/serverless-nextjs-component/README.md#custom-cloudfront-configuration |
One of the features that I always need to update is the ability to configure cloudfront. Rather than making one off input configurations for each feature (e.g. forwarding certain headers), can I suggest rather allowing one to configure any cloudfront options that are available from @serverless/aws-cloudfront, like so:
The idea is that anything you have not set could be set by these inputs. For example, I need user-agent forwarding and I want to whitelist what cloudfront allows me to do regarding headers.
This would solve #240 #198 It would also make other future requests asking for cloudfront changes obsolete.
What do you think? I can get a PR for this out quite quickly.
The text was updated successfully, but these errors were encountered: