Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws-node-mongodb-atlas code outdated #793

Open
docwarems opened this issue Aug 6, 2024 · 1 comment · May be fixed by #794
Open

aws-node-mongodb-atlas code outdated #793

docwarems opened this issue Aug 6, 2024 · 1 comment · May be fixed by #794

Comments

@docwarems
Copy link

handler.js uses client.isConnected(); this results in runtime error
I upgraded to current "mongodb" npm 6.8.0
According to research client.connect() is a no-op if already connected, so I just removed the client.isConnected() condition.

Also the MongoDB Atlas URL seems to be wrong today - at least it doesn't match mine. I just replaced it.

Last but not least, serverless.yml sets nodejs14x runtime, which is no longer supported.

I'm going to provide a PR with these minor fixes.

docwarems pushed a commit to docwarems/serverless-examples that referenced this issue Aug 7, 2024
@docwarems
Copy link
Author

#794

@docwarems docwarems linked a pull request Aug 7, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant