-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: resolve tsconfig paths #241
base: master
Are you sure you want to change the base?
Conversation
Nice work! Just a shame that there's no activity. |
Oh just noticed this was moved to the serverless org, there is hope after all! |
@perrin4869 when this change is going to be published? |
I'm not a maintainer, so no idea... I have 3 pending PRs in this repo for over a year, I'm waiting too... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code consistency
Hi @perrin4869 ! I'm trying to use your fork in my Serverless project, how do I install it so that it understands which plugin to take? Appreciate any help :) |
This finally solves the issue I've been having, and I'm sure many others that have been trying to avoid using webpack. One question is if I reference this branch I'm adding it by doing this yarn workspace foo add univapaycast/serverless-plugin-typescript#feature/tsconfig-paths Note, I already have the |
I got this working by building my own fork of this PR. This fixes the issue in question but since the code is based upon an old version of serverless-plugin-typescript it actually introduces a different issue that was working in the later version. Any chance this code could be easily upgraded to use the latest version of the servererless-plugin-typescript package? Maybe we can push them to merge it if it's updated? 🤞🏻 |
To follow up again. I actually had to revert and couldn't use the fork because it's based upon an old version of serverless-plugin-typescript and there were features that broke that I was utilizing. So still at a loss of how to add aliases without introducing webpack. Trying very hard to avoid webpack as it turns a package from 3MB to ~250MB. |
Hey, sorry I didn't look at this any longer. I am not using this module anymore, instead i use ts-node for running tests and rollup to pack the modules. I also use the relatively new package.json imports field to achieve the paths this PR was meant to implement. |
I ended up getting the plugin serverless-tscpaths to do what I needed in conjunction with |
Hi @medikoo, can you accept this PR? |
@AlanTaranti, this PR has conflicts that need to be resolved, once that's taken care of I can possibly take a look |
I fixed the conflicts real fast, but didn't test properly! May need some tuning |
Any news on thise one ? |
Would be great to have it merged! |
Closes #180
This feature is behind a custom option which is turned off by default, so this PR is backwards compatible.