Remove default case in switch case list #999
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthias-pichler
requested review from
ricardozanini and
cdavernas
as code owners
Signed-off-by: Matthias Pichler <[email protected]>
Signed-off-by: Matthias Pichler <[email protected]>
Signed-off-by: Matthias Pichler <[email protected]>
matthias-pichler
force-pushed
the
matthias-pichler/default-case-in-923
branch
from
3038990
to
74b87aa
Compare
cdavernas
requested changes
Aug 29, 2024
There was a problem hiding this comment.
As I commented in the issue, I'm not for removing the default, whenless case, but rather to properly document ordering and the possibility to instead use then.
I wasn't aware a consensus was reached on that aspect, which breaks graphical representation in many contexts, or forces authors to define another useless case.
As said in the issue, it's also a regression from what was done in 0.8/0.9, namely giving the possibility to actually name a default case.
flow6979
approved these changes
Aug 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please specify parts of this PR update:
Discussion or Issue link:
#923
What this PR does:
I updated the schema to make the
whenproperty required. A defualt case now has to be defined using the task levelthenpropertyAdditional information: