-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Features are gated by OS, not by named features #307
Comments
Named features are hard because you can't enable cargo features conditionally by target. |
That's the reason we designed render crates per target. Sadly we are having a lot of duplicated code that we have to work out. |
The problem with gating by Target OS is that there are some platforms where the OS doesn't uniquely identify them. The particular instance I'm dealing with is magicleap, which has |
In #308 I just added the gl render for android as target |
I'll have a look to see if it works. If it uses anything from libandroid the answer will be "no" :/ |
Er, that PR still gates on |
OES texture support is gated by OS at
media/backends/gstreamer/render-unix/lib.rs
Lines 9 to 15 in 6e864ed
which means that platforms (like magicleap) which support OES but aren't in the blessed list of OS's can't use the feature.
The text was updated successfully, but these errors were encountered: