Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gracefully fall back to dummy backend #329

Open
ghost opened this issue Jan 12, 2020 · 3 comments
Open

Gracefully fall back to dummy backend #329

ghost opened this issue Jan 12, 2020 · 3 comments

Comments

@ghost
Copy link

ghost commented Jan 12, 2020

As discussed in servo/servo#24829, we should gracefully fall back to the dummy backend, when the system dependencies are unavailable or fail to work.

/cc @jdm

@Manishearth
Copy link
Member

Probably should have a printed warning though

@ghost
Copy link
Author

ghost commented Jan 13, 2020

That's a good idea. Is there a central event/log system in servo for that? I suppose trying to render media elements and, when one fails, drawing a placeholder is already a thing in servo, similar to Firefox, right?

@Manishearth
Copy link
Member

Oh, just use warn!() or probably error!() from the log crate, we already use it in the codebase, e.g.

warn!("Trying to exec media action on an unknown client context");

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant