Build the embedded word lists lazily #11
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maps in vars are created at init time, resulting in something like 2.5MiB of allocation at runtime that can be problematic for programs that only optionally use the generator; this PR changes the word lists from a literal map to an explicit function that does the assignment plus a
sync.Once
. I didn't usesync.OnceValue
to keep the minimum Go requirement low.The changes should be only a handful of lines on each file if you ignore whitespace in the diff view.