Issue #2: Fixes the top month and mismatched month issue #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloverharvest
changed the title
cloverharvest
changed the title
cloverharvest
changed the title
|
Yes, thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2
=>File : lib/archives_sidebar/app/views/archives_sidebar/_content.html.erb
Taking away +1 on line 8 , redirects the user to the articles_month_path that has exact month and not the month ahead (e.g. if user clicks on March, user is brought to March page and not April).
This fix will also pave the way to address the mismatched month issue in,
=> File : lib/archives_sidebar/lib/archives_sidebar.rb
Removing the divisor 12 and +1 on line 33, makes sure that the entry count is exact, avoiding ghost counts and an empty archive month.
Removing the -1 from line 33, that the exact month is generated and not a month behind.