Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweaks to clean_names documentation and maybe tests #344

Closed
sfirke opened this issue Mar 12, 2020 · 2 comments · Fixed by #418
Closed

Tweaks to clean_names documentation and maybe tests #344

sfirke opened this issue Mar 12, 2020 · 2 comments · Fixed by #418
Assignees
Milestone

Comments

@sfirke
Copy link
Owner

sfirke commented Mar 12, 2020

Picking up from here, I want to make sure that users become aware of the great new features of clean_names from #340.

"I could see adding a test each for the issues being closed like #268 , #271 , #283 etc. and for the ones that are new features, like #271 and #283 , add that functionality to the examples of clean_names and/or make_clean_names and describe in NEWS. So people know about and use the new powers! " - me

@sfirke sfirke self-assigned this Mar 12, 2020
@sfirke sfirke added this to the v2.0 milestone Mar 12, 2020
@sfirke
Copy link
Owner Author

sfirke commented Mar 13, 2020

Annoying to do but I should update the dirty_data image and spreadsheet in the main README to have mixed date types, then use the new convert_to_date to zap them!

@sfirke
Copy link
Owner Author

sfirke commented Apr 7, 2020

Timing: I did a little bit of this in the clean_names and make_clean_names documentation. The stuff on the README should still be done but I think can be done after CRAN submission b/c I still control the GitHub README and pkgdown site and in my experience people go there for examples and how-to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant