Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for RFC6874 #6

Open
sgodwincs opened this issue Jul 14, 2019 · 4 comments · May be fixed by #26
Open

Add support for RFC6874 #6

sgodwincs opened this issue Jul 14, 2019 · 4 comments · May be fixed by #26

Comments

@sgodwincs
Copy link
Owner

See https://tools.ietf.org/html/rfc6874

@chipsenkbeil
Copy link
Contributor

I just hit this problem where I was expecting this library to support parsing IPv6 addresses as part of a URI, but it failed. @sgodwincs do you have any thoughts on the scope needed to add support for IPv6 addresses?

@sgodwincs
Copy link
Owner Author

To be clear, this library does support parsing IPv6 addresses. (unless something is broken that I'm not aware of) This RFC is in particular for supporting IPv6 addresses with zone identifiers. Are you needing to parse IPv6 addresses with zone identifiers?

@chipsenkbeil
Copy link
Contributor

@sgodwincs it turns out that the URI I was trying to parse was malformed and the IPv6 address was not wrapped in square brackets. E.g. scheme://:password@::1:12345 instead of scheme://:password@[::1]:12345.

The confusing part was that I was getting HostError::InvalidIPv4OrRegisteredNameCharacter as the error, which led me to believe that the library did not support IPv6.

@chrysn
Copy link
Contributor

chrysn commented Oct 11, 2022

Note to anyone who'd try to fix this: RFC6874 is being revised; the revising draft says that there will be no percent encoding of the percent sign any more. The reviews look positive enough that I wouldn't bother with sticking to 6874 to the letter any more.

@chrysn chrysn mentioned this issue Oct 11, 2022
chrysn added a commit to chrysn-pull-requests/uriparse-rs that referenced this issue Oct 11, 2022
@chrysn chrysn linked a pull request Oct 11, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants