-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using -start
and -end
properties for better RTL support
#1919
Comments
Thanks for your interest @TA9IO I will probably open a PR soon to work on the issue. |
there is pull request for RTL already but it is pending for a while i don't know what the plan is for that #1638 |
Did that in a pull request for all components and all styles. It is still pending but you can check it out here #1638 |
@yahia-berashish Yep like @nahasco we'll add this to the cli. Thanks for the ping @nahasco I'll add this to the queue. |
any update on this? |
I noticed that border, margin, padding, etc classes use
-left
and-right
properties, which doesn't work well for RTL pages, I suppose using-start
and-end
properties likems-
instead ofme-
would be better for accessibility and would remove a lot of work for everyone wanting to use RTL languages with shadcnUI (like Arabic for example).The changes aren't hard to implement using text search, and I can open a PR if the idea is valid.
The text was updated successfully, but these errors were encountered: