Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(www): Fix the incorrect type in Alert component #5881

Closed
wants to merge 3 commits into from

Conversation

guesung
Copy link

@guesung guesung commented Nov 20, 2024

Description

The AlertDescription and AlertTitle components had mismatched types for their refs and rendered elements. This PR updates the types to correctly match their actual DOM elements.

  1. AlertDescription: Changed from HTMLParagraphElement to HTMLDivElement to match <div> element
  2. AlertTitle: Changed from HTMLParagraphElement and HTMLHeadingElement to HTMLHeadingElement to match <h5> element

Copy link

vercel bot commented Nov 20, 2024

@guesung is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.

@denis-shvets
Copy link

denis-shvets commented Nov 20, 2024

The same fix just a few PRs ago - #5873

@guesung guesung closed this Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants