feat(dialog): add close button aria label prop for accessibility #5932
+10
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@phev8 is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal to improve the accessibility of the
Dialogcomponent by adding an optionalcloseBtnAriaLabelprop, necessary for apps with i18n. This prop allows for a customizable aria-label for the close button, enhancing screen reader support. I have run into the hard-coded "Close" label for multiple accessibility test, so likely would be useful for others as well.Accessibility improvements:
apps/www/registry/default/ui/dialog.tsx: Added an optionalcloseBtnAriaLabelprop toDialogContentand used it to set the aria-label for the close button. If not provided, it defaults to "Close". [1] [2]apps/www/registry/new-york/ui/dialog.tsx: Added an optionalcloseBtnAriaLabelprop toDialogContentand used it to set the aria-label for the close button. If not provided, it defaults to "Close". [1] [2]