Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discard zeros in sr_gui_hand_calibration #38

Open
toliver opened this issue Dec 11, 2014 · 2 comments
Open

Discard zeros in sr_gui_hand_calibration #38

toliver opened this issue Dec 11, 2014 · 2 comments
Labels

Comments

@toliver
Copy link
Contributor

toliver commented Dec 11, 2014

As reported by @jlaforga when the calibration tool averages a few raw values to obtain the one to be used for calibration, it averages one or more zeros.

These zeros are there because the topic /debug_etherCAT_data used by (https://github.com/shadow-robot/sr-ros-interface-ethercat/blob/indigo-devel/sr_robot_lib/python_lib/sr_robot_lib/etherCAT_hand_lib.py) is published before filtering out the bad ethercat frames (full of 0's).

The easiest way to fix this is to discard the zeros in the sr_gui_hand_calibration plugin itself.

@toliver
Copy link
Contributor Author

toliver commented Aug 11, 2017

The best way to fix it would be to do it when receiving the data from the debug topic here
https://github.com/shadow-robot/sr-ros-interface-ethercat/blob/indigo-devel/sr_robot_lib/python_lib/sr_robot_lib/etherCAT_hand_lib.py#L177

@biofotis
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants