Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Add X Fastener" commands redundant #355

Open
hasecilu opened this issue Mar 12, 2024 · 3 comments · May be fixed by #363
Open

"Add X Fastener" commands redundant #355

hasecilu opened this issue Mar 12, 2024 · 3 comments · May be fixed by #363

Comments

@hasecilu
Copy link
Contributor

Currently the description appears 2 times and the norm 3 times.

I think it's better to remove the description from the Menutext also I'm not sure if include again the norm in the ToolTip and don't know if the best place for the verb "Add" is the MenuText or the ToolTip.

Finally, the commands from main toolbar have "Fasteners_" prefix, the fasteners commands have "FS" maybe update that also

image

@shaise
Copy link
Owner

shaise commented Mar 12, 2024

I dont think we can change the FS command. I think it will break loading of old files with fasteners.

@hasecilu
Copy link
Contributor Author

Didn't think about that, apart from that there is no other reason to change the command because there are no Wiki pages for that.

Only is left to discuss about MenuText and ToolTip. It seems that only the ToolTip has a way to shrink long string but MenuText not. I was thinking on having it more compact (visually).

image

It seems even for Russian special cases for singular/plural is used.

@shaise
Copy link
Owner

shaise commented Mar 13, 2024

yes, definitely we need to remove the redundancy. should look like your second image. But it should not affect the pull down mode:

image

hasecilu added a commit to hasecilu/FreeCAD_FastenersWB that referenced this issue Apr 15, 2024
When the icons are not grouped in drop-down list the tooltip that
appears is bloated/redundant, this changes expect to have cleaner
tooltips.

Fix shaise#355
hasecilu added a commit to hasecilu/FreeCAD_FastenersWB that referenced this issue Apr 16, 2024
When the icons are not grouped in drop-down list the tooltip that
appears is bloated/redundant, this changes expect to have cleaner
tooltips.

Fix shaise#355
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants